RFR: 8262491: AArch64: CPU description should contain compatible board list [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Mar 2 00:12:03 UTC 2021
On Mon, 1 Mar 2021 13:59:41 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refactoring
>
> src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 180:
>
>> 178: fstat(fd, &statbuf);
>> 179: if (buflen < statbuf.st_size) {
>> 180: strncpy(buf, aarch64_label, buflen);
>
> This line is duplicated multiple times in this function, please consider reorganizing the code so we certainly copy the string before return from this function.
I fixed them in new commit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2759
More information about the hotspot-dev
mailing list