RFR: 8261142: AArch64: Incorrect instruction encoding when right-shifting vectors with shift amount equals to the element width [v11]
Dong Bo
dongbo at openjdk.java.net
Tue Mar 2 13:49:57 UTC 2021
On Tue, 2 Mar 2021 11:14:39 GMT, Eric Liu <github.com+10482586+theRealELiu at openjdk.org> wrote:
>> Dong Bo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refactor tests
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorShiftImm.java line 133:
>
>> 131: static int shift_with_op(VectorOperators.Binary op, ByteVector vbb,
>> 132: byte arr[][], int end, int ind) {
>> 133: vbb.lanewise(op, 1).intoArray(arr[end++], ind);
>
> How about adding case 0 in this test? Those codes were changed.
Thank you for watching this.
It can be covered by `lanewise(op, 8)`, `lanewise(op, 16)` and `lanewise(op, 24)`.
But I still added it, it looks clearer.
@theRealAph could you please take a look at the newest version?
The tests work well on our two very different aarch64 platforms.
Or the tests still looks too complicated?
Please let me know if you have any suggestions. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2472
More information about the hotspot-dev
mailing list