RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v6]

Mikhailo Seledtsov mseledtsov at openjdk.java.net
Tue Mar 2 18:06:47 UTC 2021


On Tue, 2 Mar 2021 11:26:21 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Using regular brackets in initializer list instead of curly brackets
>
> Hi,
> 
> Have we decided that the STL can be used now? If yes, I must have missed this. If no, could you please change the ConcurrentTestRunner to use GrowableArray or just a simply a malloced array?
> 
> Thanks!
> 
> ..Thomas

@tstuefe @iignatev 
On a question: Have we decided that the STL can be used now? 

Hi Thomas,
  I do most of my JDK work in Java, hence may have missed knowing the restriction of using STL.
I wonder if this restriction is only for source code, and not the tests. I did a quick search under "test/hotspot/gtest", and found many uses of std::, including the data structures. For instance, jfr/test_networkUtilization.cpp uses std::map, std::list and std::vector.

Thanks,
Misha

-------------

PR: https://git.openjdk.java.net/jdk/pull/2436


More information about the hotspot-dev mailing list