RFR: 8262491: AArch64: CPU description should contain compatible board list [v2]
Anton Kozlov
akozlov at openjdk.java.net
Tue Mar 2 21:14:41 UTC 2021
On Tue, 2 Mar 2021 08:23:45 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> Probably we can assume this function to optionally return a board name. IMHO ideally an empty string should a valid output. Now the output from this function is the prefix and the features string is the suffix of the complete string CPU description. What if we start with the constant `AArch64` prefix in the shared CPU code, append output from this function, and then append the features string?
>
> Do you mean `VM_Version::get_compatible_board()` should return `NULL` instead of `AArch64` to add it as a prefix at the caller?
> I don't want to do so because we should return board name as possible like a x86.
>
> In Windows AArch64, it seems to have SoC name in registry. Now I do not have Windows AArch64, so I just set "AArch64" for it, but I hope someone work for it in future.
> https://stackoverflow.com/questions/60588765/how-to-get-cpu-brand-information-in-arm64
Yes, I meant `NULL` or just `""`. Got it, you mean "AArch64" to be a placeholder. But description now starts with `AArch64` prefix, probably worth to keep it. Although it's fine in the current implementation.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2759
More information about the hotspot-dev
mailing list