RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v6]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Mar 3 15:50:41 UTC 2021
On Wed, 3 Mar 2021 14:43:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Moving these tests out of our source code is a good change.
Yes I agree. The tests were an eyesore.
> We already have a couple multithreaded tests in gtest, and adding this one isn't going to make the gtests unreliable. For future multithreaded tests, it makes sense to make them jtreg tests so that we can control their execution. So I'd like to see this PR integrated, with suggested changes.
Okay then. I am fine with this change too. I recently learned that tests can be disabled in the source code by preceding them with "DISABLED_". Not as good as ProblemLists, since it requires recompilation, but better than nothing.
---
@mseledts :
Would it be possible to rename the gtests to make them start with "os"? We recently added jtreg tests which run the "os" part of the gtests with various large page options (see https://bugs.openjdk.java.net/browse/JDK-8257959), and if you name your tests "os" too they get tested automatically with various large page settings. Which would be a nice benefit from making them gtests.
Cheers, Thomas
-------------
PR: https://git.openjdk.java.net/jdk/pull/2436
More information about the hotspot-dev
mailing list