RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v9]
Thomas Stuefe
stuefe at openjdk.java.net
Thu Mar 4 07:50:42 UTC 2021
On Fri, 26 Feb 2021 00:42:46 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Mikhailo Seledtsov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Adding os_ prefix to concurrent virtual space tests
>> - Using os:malloc instead of std::vector
>
> test/hotspot/gtest/concurrentTestRunner.inline.hpp line 100:
>
>> 98: };
>> 99:
>> 100: #endif // include guard
>
> we tend to use the expression used in the corresponding `#if` / `#ifdef` as a comment in `#endif`
"include guard" is self evident. We usually write the name of it, like this:
#endif // GTEST_CONCURRENT_TEST_RUNNER_INLINE_HPP
-------------
PR: https://git.openjdk.java.net/jdk/pull/2436
More information about the hotspot-dev
mailing list