RFR: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation [v2]

[Stefan Karlsson]

On Thu, 4 Mar 2021 18:39:02 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Marked as reviewed by stefank (Reviewer).
>
> I've messed up with this :( I'm trying to fix @stefank 's note https://github.com/openjdk/jdk/pull/2200#discussion_r572707505. I need to rename a file.hpp included in the safepoint.hpp to file.inline.hpp. This will require renaming safepoint.hpp to safepoint.inline.hpp, polluting the PR #2200 again and defeating the purpose of having this patch extracted. I think the better alternative will be a follow-up patch just renaming safepoint.hpp to safepoint.inline.hpp. I'm going to do the follow-up. Or is there a better alternative? Sorry and thanks.

Just so that I understand. Did you really mean safepoint.hpp and not safefetch.hpp? I assume this all has to do with the fact that safefetch.hpp is going to include threadWXSetter.hpp, which you are going to change to threadWXSsetter.inline.hpp, because it includes thread.inline.hpp. If that's the case then I think the easy fix is to just rename safefetch.hpp to safefetch.inline.hpp.

I don't think that will be problematic, or defeat the purpose of this patch. The previous change from stubRoutines.hpp to stubRoutines.inline.hpp has already been successfully been removed from your #2200 patch. If you create a new PR with a safefetch.hpp to safefetch.inline.hpp rename, I can review it as a trivial change and you will be able to push it immediately.

Or did I misunderstand anything? Maybe you could point me to the problematic files?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2542