RFR: 8262443: GenerateOopMap::do_interpretation can spin for a long time. [v2]

David Holmes dholmes at openjdk.java.net
Mon Mar 8 20:36:10 UTC 2021


On Mon, 8 Mar 2021 08:11:25 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> With Safepoint/Handshake timeout enabled in rare cases this methods spins for a long time, blocking safepoints/handshakes, so timeout (with a long delay) is triggered.
>> 
>> In some cases we are in native while executing this method and in some in vm.
>> That's why there is an check for state in vm.
>> 
>> Tested with other changes in t-1-7 this specific case of timeout is no longer an issue.
>> This change-set passes T1 stand alone.
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Comment, local JavaThread variable
>  - Merge branch 'master' into 8262443-gen-oop-map
>  - Go to blocked when loop

Still good.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2742


More information about the hotspot-dev mailing list