RFR: 8262377: Parallel class resolution loses constant pool error [v2]

[Coleen Phillimore]

On Tue, 9 Mar 2021 05:03:38 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary tag comparison.
>
> src/hotspot/share/classfile/vmSymbols.hpp line 538:
> 
>> 536:   template(string_void_signature,                     "(Ljava/lang/String;)V")                    \
>> 537:   template(string_int_signature,                      "(Ljava/lang/String;)I")                    \
>> 538:   template(throwable_signature,                       "Ljava/lang/Throwable;")                                    \
> 
> nit: need to align the backslash

It was aligned with one below, I moved a line down so more backslashes would match.

> src/hotspot/share/oops/constantPool.cpp line 784:
> 
>> 782: }
>> 783: 
>> 784: Symbol* exception_message(const constantPoolHandle& this_cp, int which, constantTag tag, oop pending_exception) {
> 
> Does this function need to be static?

yes.  It should be declared static.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2718