RFR: 8262913: KlassFactory::create_from_stream should never return NULL [v2]

Coleen Phillimore coleenp at openjdk.java.net
Tue Mar 9 14:32:37 UTC 2021


On Tue, 9 Mar 2021 14:15:11 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace equals with contains, suggested by hseigel.
>
> These changes look good!  One suggestion is to consider changing "getMessage().equals(" calls in the test to "getMessage().contains(". This may make the test more likely to continue passing if the exception message gets enhanced.
> Thanks, Harold

Thanks Harold, and thank you for the suggested change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2892


More information about the hotspot-dev mailing list