RFR: 8262377: Parallel class resolution loses constant pool error [v4]

David Holmes david.holmes at oracle.com
Wed Mar 10 06:48:45 UTC 2021


Fix typo in comment:

On 10/03/2021 4:26 pm, David Holmes wrote:
> src/hotspot/share/oops/constantPool.cpp line 877:
> 
>> 875:     // Needs clarification to section 5.4.3 of the VM spec (see 6308271)
>> 876:   } else if (this_cp->tag_at(which).value() != error_tag) {
>> 877:     add_resolution_error(this_cp, which, tag, PENDING_EXCEPTION);
> 
> If the CAS below fails, which is this addition of the resolution error not undone?

s/which is/why is/

I think this was pre-existing but I'm not at all clear why we leave the 
entry in the table.

Thanks,
David

> -------------
> 
> Marked as reviewed by dholmes (Reviewer).
> 
> PR: https://git.openjdk.java.net/jdk/pull/2718
> 


More information about the hotspot-dev mailing list