RFR: 8058176: [mlvm] tests should not allow code cache exhaustion [v4]

Igor Ignatyev iignatyev at openjdk.java.net
Wed Mar 10 18:07:09 UTC 2021


On Thu, 18 Feb 2021 10:04:04 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> Another approach to the JDK-8058176 and #2440 - never allowing the tests hit CodeCache limits. The most significant consumer is the MH graph builder (the MHTransformationGen), whose consumption is now controlled. List of changes:
>> 
>> * Code cache size getters are added to WhiteBox;
>> * MH sequences are now built with remaining Code cache size in mind (always let 2M clearance);
>> * Dependencies on WhiteBox added for all affected tests;
>> * The test cases in question un-problemlisted.
>> 
>> Testing: the whole vmTestbase/vm/mlvm/ in win-lin-mac x86.
>
> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add non-nmethods pool to the monitoring

Changes requested by iignatyev (Reviewer).

test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/share/MHTransformationGen.java line 104:

> 102:         NON_NMETHODS_POOL.ifPresent(pool -> check.accept(pool, 1_000_000));
> 103:         PROFILED_NMETHODS_POOL.ifPresent(pool -> check.accept(pool, 1_000_000));
> 104:         NON_PROFILED_NMETHODS_POOL.ifPresent(pool -> check.accept(pool, 1_000_000));

could you please introduce a (or two) static final field for these constants and use them here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2523


More information about the hotspot-dev mailing list