RFR: 8263434: Dangling references after MethodComparator::methods_EMCP [v2]

[Aleksey Shipilev]

On Thu, 11 Mar 2021 13:33:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Sprinkling consts
>
> src/hotspot/share/prims/methodComparator.cpp line 67:
> 
>> 65: bool MethodComparator::args_same(Bytecodes::Code c_old, Bytecodes::Code c_new,
>> 66:                                  BytecodeStream* s_old, BytecodeStream* s_new,
>> 67:                                  ConstantPool* old_cp,  ConstantPool* new_cp) {
> 
> Can these be const pointers too?

Yes, they can. Sprinkled.

> src/hotspot/share/prims/methodComparator.cpp line 262:
> 
>> 260: }
>> 261: 
>> 262: bool MethodComparator::pool_constants_same(int cpi_old, int cpi_new, ConstantPool* old_cp, ConstantPool* new_cp) {
> 
> Can these be const?

Yes, they can. Sprinkled.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2937