RFR: 8254050: HotSpot Style Guide should permit using the "override" virtual specifier

[Kim Barrett]

On Tue, 16 Mar 2021 04:06:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review and vote on this change to the HotSpot Style Guide to permit
>> the use of `override` virtual specifiers.  The virtual specifiers `override`
>> and `final` were added in C++11, and use of `final` is already permitted in
>> HotSpot code.
>> 
>> Using the `override` specifier provides error checking that the function is
>> indeed overriding a virtual function declared in a base class.  This can
>> prevent some often surprisingly difficult to spot bugs.
>> 
>> This is a modification of the Style Guide, so rough consensus among
>> the HotSpot Group members is required to make this change.  Only Group
>> members should vote for approval (via the github PR), though reasoned
>> objections or comments from anyone will be considered.  A decision on
>> this proposal will not be made before Tuesday 30-Mar-2021 at 12h00 UTC.
>> 
>> Since we're piggybacking on github PRs here, please use the PR review
>> process to approve (click on Review Changes > Approve), rather than
>> sending a "vote: yes" email reply that would be normal for a CFV.
>> Other responses can still use email of course.
>
> Fine by me.
> 
> Thanks,
> David

I forgot to mention that I didn't bother including the generated html in the PR, because it doesn't really add anything for the review, but will include it before integrating.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3021