RFR: JDK-8260332: ParallelGC: Cooperative pretouch for oldgen expansion [v2]
Amit Pawar
github.com+71302734+amitdpawar at openjdk.java.net
Tue Mar 16 06:19:09 UTC 2021
On Sun, 14 Mar 2021 21:27:50 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Amit Pawar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed build issues for some targets and updated with suggested changes.
>
> src/hotspot/share/gc/shared/pretouchTask.cpp line 66:
>
>> 64:
>> 65: // Following atomic loads are required to make other processor store
>> 66: // visible to all threads from this points.
>
> That is not what an Atomic::load does; they only protect against word-tearing (which is only a theoretical possibility on some platforms). If you want to guarantee those loads see the most recent store then the fence needs to come first.
Thank you David for your reply and will do as suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2976
More information about the hotspot-dev
mailing list