RFR: 8254050: HotSpot Style Guide should permit using the "override" virtual specifier

[Daniel D.Daugherty]

On Tue, 16 Mar 2021 03:44:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review and vote on this change to the HotSpot Style Guide to permit
> the use of `override` virtual specifiers.  The virtual specifiers `override`
> and `final` were added in C++11, and use of `final` is already permitted in
> HotSpot code.
> 
> Using the `override` specifier provides error checking that the function is
> indeed overriding a virtual function declared in a base class.  This can
> prevent some often surprisingly difficult to spot bugs.
> 
> This is a modification of the Style Guide, so rough consensus among
> the HotSpot Group members is required to make this change.  Only Group
> members should vote for approval (via the github PR), though reasoned
> objections or comments from anyone will be considered.  A decision on
> this proposal will not be made before Tuesday 30-Mar-2021 at 12h00 UTC.
> 
> Since we're piggybacking on github PRs here, please use the PR review
> process to approve (click on Review Changes > Approve), rather than
> sending a "vote: yes" email reply that would be normal for a CFV.
> Other responses can still use email of course.

Marked as reviewed by dcubed (Reviewer).

doc/hotspot-style.md line 753:

> 751: ([n2928](http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2009/n2928.htm)),
> 752: ([n3206](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2010/n3206.htm)),
> 753: ([n3272](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3272.htm))

nit - The difference in case caught my attention:

    JTC1 <-> jtc1
    SC22 <-> sc22
    WG21 <-> wg21

any particular significance to the difference?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3021