RFR: 8263260: [s390] Support latest hardware (z14 and z15)

[Martin Doerr]

On Wed, 10 Mar 2021 17:35:20 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> 8263260: [s390] Support latest hardware (z14 and z15)

Detection looks good to me.
Cleanup proposal: Try to make dates more consistent and comprehensive.

src/hotspot/cpu/s390/vm_version_s390.cpp line 54:

> 52: static const char* z_name[]    = {"  ", "z900",       "z990",       "z9 EC",      "z10 EC",     "z196 EC",    "ec12",       "z13",        "z14",        "z15" };
> 53: static const char* z_WDFM[]    = {"  ", "2006-06-30", "2008-06-30", "2010-06-30", "2012-06-30", "2014-06-30", "2016-12-31", "2019-06-30", "2021-06-30", "tbd" };
> 54: static const char* z_EOS[]     = {"  ", "2014-12-31", "2014-12-31", "2017-10-31", "2019-12-31", "2021-12-31", "tbd",        "tbd",        "tbd",        "tbd" };

Table provides a nice overview, but seems like only z_name is used in the code. The rest only serves as comments.

src/hotspot/cpu/s390/vm_version_s390.cpp line 309:

> 307:   }
> 308:   if (is_z9()) {
> 309:     _features_string = "system-z, g3-z9, ldisp_fast, extimm, out-of-support_as_of_2016-04-01";

How does this relate to the table above?

src/hotspot/cpu/s390/vm_version_s390.hpp line 48:

> 46: //   z13:  2015-03
> 47: //   z14:  2017-09
> 48: //   z15:  2019-09

How does this relate to the table in the .cpp file? I'd prefer to have such kind of information consolidated at one place.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2918