RFR: 8263659: Reflow GTestResultParser for better readability

Alex Blewitt github.com+76791+alblue at openjdk.java.net
Thu Mar 18 15:49:38 UTC 2021


On Tue, 16 Mar 2021 09:17:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> As noted by https://sonarcloud.io/code?id=shipilev_jdk&selected=shipilev_jdk%3Atest%2Fhotspot%2Fjtreg%2Fgtest%2FGTestResultParser.java there are a few fixes that can be applied for the GTestResultParser:
>> 
>> * Avoiding nested 'try' statements
>> * Avoiding nested 'switch' statements
>> * Adding a break for each switch case to prevent accidental/unwanted fall-through
>> * Disabling ability to load from remote files when parsing XML files
>
> Please change this PR synopsis to "8263659: Reflow GTestResultParser for better readability" to get this hooked properly. Also, enable testing, see "Pre-submit test status" in "Checks".

One of the test jobs hasn't finished running according to the above, but has if you drill down into the check itself. Is that blocking this PR moving forwards? Should I try to re-run the checks?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2991


More information about the hotspot-dev mailing list