RFR: 8263659: Reflow GTestResultParser for better readability
Igor Ignatyev
iignatyev at openjdk.java.net
Thu Mar 18 15:57:43 UTC 2021
On Sat, 13 Mar 2021 22:13:39 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:
> As noted by https://sonarcloud.io/code?id=shipilev_jdk&selected=shipilev_jdk%3Atest%2Fhotspot%2Fjtreg%2Fgtest%2FGTestResultParser.java there are a few fixes that can be applied for the GTestResultParser:
>
> * Avoiding nested 'try' statements
> * Avoiding nested 'switch' statements
> * Adding a break for each switch case to prevent accidental/unwanted fall-through
> * Disabling ability to load from remote files when parsing XML files
LGTM. @alblue, thanks for fixing that.
-------------
Marked as reviewed by iignatyev (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2991
More information about the hotspot-dev
mailing list