RFR: 8263974: Move SystemDictionary::verify_protection_domain

[Harold Seigel]

On Mon, 22 Mar 2021 14:57:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Please review this mostly trivial fix to move SystemDictionary::validate_protection_domain into Dictionary and hide the functions in Dictionary that it calls.  This change also removes some #include dictionary.hpp and a TRAPS parameter where not needed.
> 
> See CR for more details.  This function was in the middle of others that I want to keep together in systemDictionary.cpp.
> 
> Tested with tier1 on 4 Oracle supported platforms.

Other than that one nit, this looks good.
Thanks, Harold

src/hotspot/share/classfile/dictionary.cpp line 362:

> 360:                                             TRAPS) {
> 361: 
> 362:   // Now we have to call back to java to check if the initating class has access

Can you move this comment down about 10 lines?

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3120