RFR: 8263974: Move SystemDictionary::verify_protection_domain [v2]
David Holmes
dholmes at openjdk.java.net
Tue Mar 23 04:40:40 UTC 2021
On Mon, 22 Mar 2021 18:06:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Please review this mostly trivial fix to move SystemDictionary::validate_protection_domain into Dictionary and hide the functions in Dictionary that it calls. This change also removes some #include dictionary.hpp and a TRAPS parameter where not needed.
>>
>> See CR for more details. This function was in the middle of others that I want to keep together in systemDictionary.cpp.
>>
>> Tested with tier1 on 4 Oracle supported platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Move comment down to the code it describes.
Looks good!
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3120
More information about the hotspot-dev
mailing list