RFR: 8263992: Remove dead code NativeLookup::base_library_lookup [v2]
David Holmes
dholmes at openjdk.java.net
Tue Mar 23 05:34:40 UTC 2021
On Tue, 23 Mar 2021 05:07:56 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Please review this removal of dead code, and unused parameter of `in_base_library` for the functions that remain. The word `base_library_lookup` does not exist in any C source code in the entire JDK.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> removed unused "in_base_library" parameter; removed unnecessary include of nativeLookup.hpp
Looks even better! Thanks.
Of course now I'm going to have to go and find out why in_base_library was introduced :)
Cheers,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3139
More information about the hotspot-dev
mailing list