RFR: 8264051: Remove unused TRAPS parameters from runtime functions [v2]

Coleen Phillimore coleenp at openjdk.java.net
Wed Mar 24 03:22:05 UTC 2021


On Wed, 24 Mar 2021 03:07:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/oops/instanceKlass.hpp line 468:
>> 
>>> 466:   void set_nest_host_index(u2 i)  { _nest_host_index = i; }
>>> 467:   // dynamic nest member support
>>> 468:   void set_nest_host(InstanceKlass* host, JavaThread* current);
>> 
>> I think we should drop the thread parameter for this method and nest_host_error and avoid the tramp data. We only need the current thread for a ResourceMark in a logging clause in set_nest_host, and for a ConstantPoolHandle in nest_host_error. Neither of these codepaths are hot so we can just manifest Thread::current() when needed there.
>> Then you can also remove the thread parameter from print_nest_host_error_on.
>
> You're right. I can remove a lot of thread arguments this way.

Done.  Reran runtime/Nestmates tests and tier1.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3157


More information about the hotspot-dev mailing list