RFR: 8264051: Remove unused TRAPS parameters from runtime functions [v2]

David Holmes dholmes at openjdk.java.net
Wed Mar 24 03:52:40 UTC 2021


On Wed, 24 Mar 2021 03:22:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes the TRAPS parameter from compute_modifier_flags(), lookup_instance_method_in_klasses and nest_host_error.
>> 
>> There's a progressive effort to remove cases where the last parameter of a function is THREAD, and it's unclear why it is ignoring an exception or whether an exception is expected, if it doesn't subsequently have a check for HAS_PENDING_EXCEPTION.
>> 
>> Tested locally with tier1 tests and tier1 tests on 4 Oracle platforms in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed thread parameter from nest_host_error and callers.

Looks good!

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3157


More information about the hotspot-dev mailing list