RFR: 8262291: Refactor reserve_memory_special_huge_tlbfs [v2]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Wed Mar 24 17:22:45 UTC 2021


On Tue, 23 Mar 2021 20:16:52 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 3981:
>> 
>>> 3979:   // and the given alignment. The larger of the two will be used.
>>> 3980:   size_t required_alignment = MAX(os::large_page_size(), alignment);
>>> 3981:   char* const aligned_start = anon_mmap_aligned(req_addr, bytes, required_alignment);
>> 
>> Do we need to add back the comment "// First reserve - but not commit"?
>
> My hope was that the new comment would be sufficient, but if you think it is needed I could add that the reserved range is not committed here.

I agree that current comment encompasses `// First reserve - but not commit`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3073


More information about the hotspot-dev mailing list