RFR: 8264016: [JVMCI] add some thread local fields for use by JVMCI
Coleen Phillimore
coleenp at openjdk.java.net
Wed Mar 24 18:46:40 UTC 2021
On Wed, 24 Mar 2021 06:04:15 GMT, Tom Rodriguez <never at openjdk.org> wrote:
>> src/hotspot/share/runtime/thread.hpp line 1020:
>>
>>> 1018: intptr_t* _jvmci_reserved0;
>>> 1019: intptr_t* _jvmci_reserved1;
>>> 1020: oop _jvmci_reserved_oop0;
>>
>> Can this use OopStorage? We've been getting rid of oop fields and the corresponding oops_do support.
>
> Wouldn't using OopStorage require an extra level of indirection for the field?
It was https://bugs.openjdk.java.net/browse/JDK-8244997 - you were co-author :)
Maybe this jvmci_reserved_oop0 won't crash for the same reasons. I don't know that.
I still would like to not see 45 lines of declarations for JVMCI added to JavaThread. These should be in a separate header file and declared, as in https://bugs.openjdk.java.net/browse/JDK-8137018. If you promise to fix 8137018, I'm fine with this change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3147
More information about the hotspot-dev
mailing list