RFR: 8262291: Refactor reserve_memory_special_huge_tlbfs [v2]
Stefan Johansson
sjohanss at openjdk.java.net
Wed Mar 24 20:29:11 UTC 2021
On Wed, 24 Mar 2021 13:15:04 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Ivan review
>>
>> Renamed helper to commit_memory_special and updated the comments.
>
> lgtm!
> Suggestions are mostly nits, if the assumption in my comment about un-mapping is correct (I suspect so based on your conversation with Ivan (@walulyai)). Looks good otherwise from my perspective.
Thanks for reviewing Marcus, updated the comments per your suggestion and also changed one to better fit the flow.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3073
More information about the hotspot-dev
mailing list