RFR: 8264126: Remove TRAPS/THREAD parameter for class loading functions [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Thu Mar 25 02:59:40 UTC 2021
On Thu, 25 Mar 2021 02:20:15 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improvements suggested by Ioi.
>
> Hi Coleen,
>
> Generally this looks good, but I'm with Ioi here that where we pass through the current thread to avoid needing to manifest Thread::current down the stack (for MutexLockers or ResourceMarks etc) then I would prefer to see that kept - and if necessary relocate the Thread parameter to the beginning. In the past we have consciously added these thread parameters to avoid the Thread::current calls and I prefer not to see that undone. But it is very subjective - I removed one only needed for logging code for example.
>
> Thanks,
> David
Added back a thread parameter and rerunning tier1 sanity tests.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3176
More information about the hotspot-dev
mailing list