RFR: 8263582: WB_IsMethodCompilable ignores compiler directives

[Igor Veresov]

On Thu, 25 Mar 2021 15:00:39 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> While playing around with `WB_IsMethodCompilable` together with `compileonly` I ran into some surprising results for methods that should never be compiled (not part of `compileonly`): `isMethodCompilable` returns true instead of false when such an excluded method was not yet tried to be compiled. 
> 
> The reason for it is that `WB_IsMethodCompilable` directly checks `CompilationPolicy::can_be_compiled()` which calls `Method::is_not_compilable()`. However, the `ExcludeOption` compiler directive is only evaluated lazily upon a compilation attempt. Therefore, if a method was not tried to be compiled, yet, `Method::is_not_compilable()` always returns false, regardless of any set compiler directive.
> 
> I therefore suggest to additionally check the `ExcludeOption` in `WB_IsMethodCompilable`. I also cleaned up some wrong use of `CompLevel_any` and `CompLevel_all` as suggested by @veresov: `CompLevel_any` should only be used to query the state as in `is_*()` methods and `CompLevel_all` when changing the state is in `set_*()` methods.
> 
> Thanks,
> Christian

Marked as reviewed by iveresov (Reviewer).

test/hotspot/jtreg/compiler/whitebox/TestMethodCompilableCompilerDirectives.java line 64:

> 62:     // to prevent a compilation is evaluated lazily and is only applied when a compilation for m is attempted.
> 63:     // Another problem is that Method::is_not_compilable() only returns true for CompLevel_any if C1 AND C2 cannot compile it.
> 64:     // This means that a compilation of m must have been attempted for C1 and C2 before WB::isMethodCompilable(m, CompLevl_any) will

A typo "CompLevl_any" -> "CompLevel_any".

-------------

PR: https://git.openjdk.java.net/jdk/pull/3195