RFR: 8264126: Remove TRAPS/THREAD parameter for class loading functions [v4]

Ioi Lam iklam at openjdk.java.net
Fri Mar 26 00:00:28 UTC 2021


On Thu, 25 Mar 2021 22:26:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix broken logic in systemDictionaryShared.
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1864:
> 
>> 1862:   }
>> 1863: 
>> 1864:   if (DynamicDumpSharedSpaces && Thread::current()->is_VM_thread()) {
> 
> This is still a functional change. If there is a bug and we get here in the VMThread when DynamicDumpSharedSpaces is not set then we will no longer immediately return.

That's fine. In debug build, we will assert both before/after this change. In product build, after this change, some duplicated info will be added via info->record_linking_constraint but it won't hurt.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3176


More information about the hotspot-dev mailing list