RFR: 8263582: WB_IsMethodCompilable ignores compiler directives [v2]
Christian Hagedorn
chagedorn at openjdk.java.net
Fri Mar 26 08:58:27 UTC 2021
On Thu, 25 Mar 2021 17:19:13 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix typo
>
> src/hotspot/share/prims/whitebox.cpp line 869:
>
>> 867: // Both compilers could have ExcludeOption set. Check all combinations.
>> 868: bool excluded_c1 = is_excluded_for_compiler(CompileBroker::compiler1(), mh);
>> 869: bool excluded_c2 = is_excluded_for_compiler(CompileBroker::compiler2(), mh);
>
> May be use next instead as we do in `WhiteBox::compile_method` at line #992:
> *comp = CompileBroker::compiler(comp_level);```
The problem is that `CompileBroker::compiler()` returns `NULL` for `CompLevel_any`. And even if it returned one compiler, I also need to check the other one to decide if the method is completly non-compilable. That's why I added this additional logic for `CompLevel_any`.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3195
More information about the hotspot-dev
mailing list