RFR: 8264268: Don't use oop types for derived pointers [v3]
Stefan Karlsson
stefank at openjdk.java.net
Mon Mar 29 09:35:58 UTC 2021
> The JIT compiler embeds pointers to addresses within an object. These are called derived pointers. When the GC moves objects, these pointers need to be updated explicitly, because the GC only deals with the real oops of the objects (base pointer).
>
> The code that deals with this uses oop* for the address containing the base pointer. This is fine, the address contains an oop. However, it also uses oop* for the interior pointer, even though the contents is not a valid oop.
>
> This creates temporary oops that does not conform to the normal requirements for oops. For example, the lower three bits could be set. This makes it problematic to write stricter verification code.
>
> I propose that we use intptr_t* instead of oop*, and only use oop* when the location is known to contain a valid oop.
Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
Remove unused value_fn parameter
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3214/files
- new: https://git.openjdk.java.net/jdk/pull/3214/files/d231e3ba..1318ab6a
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3214&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3214&range=01-02
Stats: 7 lines in 2 files changed: 0 ins; 2 del; 5 mod
Patch: https://git.openjdk.java.net/jdk/pull/3214.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3214/head:pull/3214
PR: https://git.openjdk.java.net/jdk/pull/3214
More information about the hotspot-dev
mailing list