RFR: 8264268: Don't use oop types for derived pointers [v3]

Stefan Karlsson stefank at openjdk.java.net
Mon Mar 29 09:36:02 UTC 2021


On Sun, 28 Mar 2021 04:43:37 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused value_fn parameter
>
> src/hotspot/share/compiler/oopMap.cpp line 196:
> 
>> 194: }
>> 195: 
>> 196: static void add_derived_oop(oop* base, intptr_t* derived, OopClosure* oop_fn) {
> 
> `add_derived_oop` and `ignore_derived_oop` ignore `oop_fn`.  Maybe they should assert that it's `&do_nothing_cl` ?

Hmm. `&do_nothing_cl` isn't being passed down to `oop_fn`. It's being passed down as `value_fn`, which isn't used at all. I've pushed a commit to remove this, to make it less confusing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3214


More information about the hotspot-dev mailing list