RFR: 8264173: [s390] Improve Hardware Feature Detection And Reporting [v2]
Lutz Schmidt
lucy at openjdk.java.net
Mon Mar 29 10:36:48 UTC 2021
On Mon, 29 Mar 2021 10:19:02 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update copyright headers
>
> I didn't expect the change to become that large. But it looks good to me. The lengthy output only gets generated with -XX:+Verbose. That's fine.
Thank you for the review, Martin!
> src/hotspot/cpu/s390/vm_version_s390.cpp line 94:
>
>> 92:
>> 93: if (Verbose || PrintAssembly || PrintStubCode) {
>> 94: print_features_internal("CPU Version as detected internally: ", PrintAssembly || PrintStubCode);
>
> 2 spaces while other usages have no spaces?
You are right. These spaces were excessive. Now they are gone.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3196
More information about the hotspot-dev
mailing list