RFR: 8264346: nullptr_t undefined in global namespace for clang+libstdc++ [v2]
Kim Barrett
kbarrett at openjdk.java.net
Wed Mar 31 14:23:27 UTC 2021
On Wed, 31 Mar 2021 07:11:52 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> There's a mismatch in some toolchains about what part should provide the nullptr_t definition. This patch takes the easy way out and include cstddef and changes the two usages nullptr_t to std::nullptr_t.
>>
>> See the bug report for more details.
>>
>> We could have redefined nullptr_t to resolve this, but that would have required more extensive testing, so I left that as a potential future cleanup.
>>
>> I've tested this by compiling with clang on linux. I'm going to let GHA testing testing run, and will also run our tier1 testing.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>
> Review Kim
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3269
More information about the hotspot-dev
mailing list