Integrated: 8264346: nullptr_t undefined in global namespace for clang+libstdc++
Stefan Karlsson
stefank at openjdk.java.net
Wed Mar 31 16:47:18 UTC 2021
On Tue, 30 Mar 2021 14:46:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> There's a mismatch in some toolchains about what part should provide the nullptr_t definition. This patch takes the easy way out and include cstddef and changes the two usages nullptr_t to std::nullptr_t.
>
> See the bug report for more details.
>
> We could have redefined nullptr_t to resolve this, but that would have required more extensive testing, so I left that as a potential future cleanup.
>
> I've tested this by compiling with clang on linux. I'm going to let GHA testing testing run, and will also run our tier1 testing.
This pull request has now been integrated.
Changeset: dec34470
Author: Stefan Karlsson <stefank at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/dec34470
Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
8264346: nullptr_t undefined in global namespace for clang+libstdc++
Reviewed-by: dholmes, kbarrett
-------------
PR: https://git.openjdk.java.net/jdk/pull/3269
More information about the hotspot-dev
mailing list