RFR: 8264538: Rename SystemDictionary::parse_stream [v2]
Harold Seigel
hseigel at openjdk.java.net
Wed Mar 31 20:30:20 UTC 2021
On Wed, 31 Mar 2021 19:57:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This function is used to call the classfile parser for hidden or anonymous classes, and for use with jvmti RedefineClasses. The latter only calls KlassFactory::create_from_stream and skips the rest of the code in SystemDictionary::parse_stream.
>>
>> Renamed SystemDictionary::parse_stream -> resolve_hidden_class_from_stream
>> resolve_from_stream -> resolve_class_from_stream
>> and have SystemDictionary::resolve_from_stream() call the right version depending on ClassLoadInfo flags. Callers of resolve_from_stream now pass protection domain via. ClassLoadInfo.
>>
>> So the external API is resolve_from_stream.
>>
>> Tested with tier1 on 4 Oracle supported platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> fifix comment
src/hotspot/share/prims/jvmtiRedefineClasses.hpp line 305:
> 303: // - How do we serialize the RedefineClasses() API without deadlocking?
> 304: //
> 305: // - KlassFactory::create_from_stream() was called with a NULL protection
Maybe delete the comment that goes from lines 305 - 309 ?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3289
More information about the hotspot-dev
mailing list