RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v13]

[Ioi Lam]

On Mon, 3 May 2021 17:18:13 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>> 
>>   When do dynamic dump, the pre-generated lambda form classes from java.lang.invoke are not stored in dynamic archive. The patch will regenerate the four holder classes, 
>>      "java.lang.invoke.Invokers$Holder",
>>      "java.lang.invoke.DirectMethodHandle$Holder",
>>      "java.lang.invoke.DelegatingMethodHandle$Holder",
>>      "java.lang.invoke.LambdaForm$Holder"
>>   which will include the versions in static archive and new loaded functions all together and stored in dynamic archive. New test case added.
>>   (Minor change to PrintSharedArchiveAtExit, which the index is not consecutive)
>> 
>>   Tests: tier1,tier2,tier3,tier4
>>   
>>   Thanks
>>   Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   LambdaFormInvokers::reload should take CHECK

LGTM. Just a small nit about comments.

src/hotspot/share/cds/lambdaFormInvokers.hpp line 44:

> 42:   static void append_filtered(char* line);
> 43:   // All exceptions except for OOM will be suppressed in the fucntion, the
> 44:   // non-OOM failure should not affect normal archiving.

The above comments should be removed, since we do throw exceptions if the generated classfiles are invalid.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3611