RFR: 8266491: Remove resolve and obj_equals leftovers from BarrierSetAssembler

Thomas Schatzl tschatzl at openjdk.java.net
Tue May 4 11:38:55 UTC 2021


On Tue, 4 May 2021 11:01:04 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Shenandoah used to require resolve() and obj_equals() in its first incarnation in JDK12. This is long obsolete, and the corresponding code can be removed from BarrierSetAssembler. It also makes the code less confusing because obj_equals() and resolve() have both been rather clunky and given that they now do nothing (and there are other resolve* methods in BSA too), it's not even clear what they would be supposed to do. It also makes life easier for porters to other platforms.
> 
> Testing:
>  - [x] Build x86_64, x86_32
>  - [x] hotspot_gc_shenandoah
>  - [ ] tier1, tier2
>  - [ ] Build arm, aarch64 (by GH-actions)

Lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3850


More information about the hotspot-dev mailing list