RFR: 8229517: Support for optional asynchronous/buffered logging [v10]

[Thomas Stuefe]

On Mon, 3 May 2021 23:30:20 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch provides a buffer to store asynchrounous messages and flush them to
>> underlying files periodically.
>
> Xin Liu has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Implement the global option -Xlog:async per CSR.
>    
>    The old options -XX:+AsyncLogging and the output option are both removed.
>    This patch also deliver the zero-cost promise. ie. No AsyncLog thread will be
>    launched if async_mode is not eanbled.
>  - Reimplement Accurate Decorations for AsyncLogging.
>    
>    LogDecorations defines a copy constructutor. Each log message copys it
>    once.
>  - Revert "Accurate Decorations for AsyncLogging."
>    
>    This reverts commit 1f06be3126f829055aff3720aea7e82544fd0c3a.

Hi Xin,

I put https://github.com/openjdk/jdk/pull/3855 up for review. Please take a look at it. It makes LogDecorations trivially copy-able, and it reduces its size by about a quarter too. With this patch I believe you can do without your new LogDecorations copy constructor as well as the deleted assignment op since the default copy constructor and assignment operator should work fine now.

I do not understand why you make the _tagset member in LogDecorations optional. Could you explain this?

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135