RFR: 8256155: Allow multiple large page sizes to be used on Linux [v32]

[Thomas Stuefe]

On Fri, 7 May 2021 16:16:22 GMT, Marcus G K Williams <mgkwill at openjdk.org> wrote:

>> Change the meaning of LargePageSizeInBytes to be the maximum large page size the JVM may use (not the only one). A default value of zero will mean to allow the JVM use large page sizes up to the system's default large page size.
>
> Marcus G K Williams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 53 commits:
> 
>  - Remove reserve_memory_special_huge_tlbfs mods except assert
>    
>    Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>  - Merge branch 'master' into update_hlp
>  - Merge branch 'master' into update_hlp
>  - Remove extranous vm_page_size check
>    
>    Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>  - kstefanj review
>    
>    Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>  - Set LargePageSizeInBytes to largepage upper limit
>    
>    Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>  - Merge branch 'master' into update_hlp
>  - Fix merge
>    
>    Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>  - Merge branch 'master' into update_hlp
>  - Merge branch 'master' into update_hlp
>  - ... and 43 more: https://git.openjdk.java.net/jdk/compare/0790e601...7368e7d4

The build warning makes not much sense to me, and is not reproducable. None of the callers of log_phase hands in any indentation > 4. 

However, that indentation code is a bit inelegant anyway. @mgkwill : can you test this patch, does this fix your build? : https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/3934.diff

This uses outputStream::sp() to print indentation. Note that in places where that's not convenient, and I want to go via format string instead I usually do something like this:

static const char* spaces = "                        ...   ";
..
out->print("%.*s", indentation, spaces);


That way you don't have to keep a const indentation string for every level. If you miss the assert, it could be squeezed in too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153