RFR: 8229517: Support for optional asynchronous/buffered logging [v11]

Xin Liu xliu at openjdk.java.net
Tue May 11 06:35:57 UTC 2021


On Thu, 6 May 2021 15:21:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use LogTagSetMapping<LogTag::__NO_TAG>::tagset() instead of NULL pointer.
>
> src/hotspot/share/logging/logAsyncFlusher.hpp line 86:
> 
>> 84:   LogFileOutput&   _output;
>> 85:   LogDecorations*  _decorations;
>> 86:   char*            _message;
> 
> I would keep decorations by value here. They are small enough.

I has changed that to by value. no perf regression has been detected. 
yes, there's one unnecessary copying imposed by <linkedlist.hpp> 
It's fine because you have shrunk sizeof(LogDecorations) a lot.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135


More information about the hotspot-dev mailing list