RFR: 8229517: Support for optional asynchronous/buffered logging [v14]
Xin Liu
xliu at openjdk.java.net
Thu May 13 07:10:57 UTC 2021
On Thu, 13 May 2021 06:30:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix build on Windows.
>>
>> It seems that headers on Windows define WAIT_TIMEOUT somewhere. rename it.
>
> src/hotspot/share/logging/logAsyncFlusher.cpp line 42:
>
>> 40: assert_lock_strong(&_lock);
>> 41:
>> 42: if (_buffer.size() >= _buffer_max_size) {
>
> As mentioned in the CSR, I prefer dropping the newest message, not the oldest one. So there would be no reason to pop anything from the buffer.
copy that. I will update it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list