RFR: 8229517: Support for optional asynchronous/buffered logging [v14]
Xin Liu
xliu at openjdk.java.net
Thu May 13 08:20:00 UTC 2021
On Thu, 13 May 2021 06:23:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix build on Windows.
>>
>> It seems that headers on Windows define WAIT_TIMEOUT somewhere. rename it.
>
> src/hotspot/share/logging/logAsyncFlusher.cpp line 39:
>
>> 37: }
>> 38:
>> 39: void LogAsyncFlusher::enqueue_impl(const AsyncLogMessage& msg) {
>
> Could you rename this to enqueue_locked? We use this name at other places for functions which factor out locking to the caller.
okay.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list