RFR: 8267213: assert(left >= right) failed: avoid underflow

David Holmes dholmes at openjdk.java.net
Mon May 17 06:48:39 UTC 2021


On Mon, 17 May 2021 03:56:22 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> This is a follow-up of JDK-8260046.
> And it can be reproduced by `java -XX:UnguardOnExecutionViolation=1` on x86_32.
> Let's fix it
> 
> Thanks.
> Best regards,
> Jie

Hi Jie,

I'm not sure this is the right fix. It seems to me from the comments about having a sane addr and pc that the basic assumption/premise is that addr > pc as it is being checked when expected to be part of the current instruction. So if addr < pc I would think pc_is_near_addr should be false.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/4044


More information about the hotspot-dev mailing list