RFR: 8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
Albert Mingkun Yang
ayang at openjdk.java.net
Mon May 17 12:22:23 UTC 2021
`RestorePreservedMarks`, and `RemoveSelfForwardingPtr` are conditionally emitted (only on evac failure). Updating the test to exclude these events in the assert.
double G1GCPhaseTimes::print_post_evacuate_collection_set() const {
...
debug_phase(_gc_par_phases[RecalculateUsed], 1);
if (G1CollectedHeap::heap()->evacuation_failed()) {
debug_phase(_gc_par_phases[RemoveSelfForwardingPtr], 1);
}
debug_time("Post Evacuate Cleanup 2", _cur_post_evacuate_cleanup_2_time_ms);
if (G1CollectedHeap::heap()->evacuation_failed()) {
debug_phase(_gc_par_phases[RecalculateUsed], 1);
debug_phase(_gc_par_phases[RestorePreservedMarks], 1);
}
...
}
Tested: manually set a smaller heap size to see the test fail, but pass with the PR.
-------------
Commit messages:
- remove string dedup event
- evac-failure
Changes: https://git.openjdk.java.net/jdk/pull/4056/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4056&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8267133
Stats: 7 lines in 2 files changed: 4 ins; 3 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/4056.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4056/head:pull/4056
PR: https://git.openjdk.java.net/jdk/pull/4056
More information about the hotspot-dev
mailing list