RFR: 8265292: [macos_aarch64] java/foreign/TestDowncall.java crashes with SIGBUS

[Andrew Haley]

On Mon, 17 May 2021 10:43:35 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

> > This looks to me like an instance of the Temporal Coupling design smell.
> 
> I would agree if we'd change the W^X as necessary before an appropriate action. But we don't, we maintain a property "JVM's runtime (C++) code runs in WXWrite" (now it is specified in one of the comments). And the change restores this property which was just broken inadvertently.

Sure, but this code has not been in mainline for very long. I have no objection to this patch being committed, which is obviously necessary, but I agree with David Holmes. If we're quick we can get this fixed before it ever reaches a release.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3921