RFR: 8266332: Adler32 intrinsic for x86 64-bit platforms [v11]

Tue May 18 21:01:51 UTC 2021

On Tue, 18 May 2021 19:45:52 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> Xubo Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove scratch register from vpmulld
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 7859:
> 
>> 7857: void Assembler::vbroadcastf128(XMMRegister dst, Address src, int vector_len) {
>> 7858:   assert(VM_Version::supports_avx(), "");
>> 7859:   assert(vector_len == AVX_256bit, "");
> 
> Looks like "vector_len" can only be AVX_256bit. Do we really need a parameter then?

your are right, for now it can only be AVX_256bit. But I think in the future other lengths will be used too. So we should have a more generic signature.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3806