RFR: JDK-8267371: Concurrent gtests take too long [v2]

Gerard Ziemski gziemski at openjdk.java.net
Wed May 19 16:54:39 UTC 2021


On Wed, 19 May 2021 14:59:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> More than half of the total runtime of the gtests is currently used by just three tests:
>> 
>> - VirtualSpace.os_reserve_space_concurrent_vm
>> - VirtualSpace.os_virtual_space_concurrent_vm
>> - os_linux.reserve_memory_special_concurrent_vm
>> 
>> These tests do concurrent tests with 30 threads, with a timeout of 15 seconds each.
>> 
>> Since we run the gtests with several configurations (see hotspot/jtreg/gtests) these numbers multiply, which hurts especially when run as part of tier1. I think we can safely reduce the timeouts, still have good test coverage and recover some of the gtest runtime.
>> 
>> ---
>> 
>> The patch reduces the timeout to 5 seconds, which reduces the time for one gtest by 30 seconds from 80 seconds down to 50 seconds.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   5 threads 3 secs

Had to take look at the `ConcurrentTestRunner` to make sure I understood the parameters:

`ConcurrentTestRunner(TestRunnable* const runnableArg, int nrOfThreadsArg, long testDurationMillisArg)`

Looks good, thank you for fixing it!

-------------

Marked as reviewed by gziemski (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4110


More information about the hotspot-dev mailing list