RFR: 8229517: Support for optional asynchronous/buffered logging [v16]

Xin Liu xliu at openjdk.java.net
Thu May 20 08:55:42 UTC 2021


On Wed, 19 May 2021 13:16:44 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement the new discard policy: drop the incoming message.
>>   
>>   This patch also fix a bug. meta messages append to the temp logs instead
>>   of directly calling output->write_blocking(). This guranatees logsites are non-blocking.
>
> test/hotspot/gtest/logging/logTestUtils.inline.hpp line 24:
> 
>> 22:  */
>> 23: 
>> 24: #include "jvm.h"
> 
> Why do you need this extra include if there are no other changes in this file?

logTestUtils.inline.hpp uses 'jio_snprintf', which is declared in jvm_io.h. 
I found that gtests included jvm.h ahead of include "logTestUtils.inline.hpp". 
I will define in the the way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135


More information about the hotspot-dev mailing list